Opened on 07/17/2015 at 01:21:40 PM
Closed on 01/04/2018 at 10:10:49 PM
Last modified on 06/05/2018 at 09:53:30 PM
#2801 closed change (fixed)
Create 'Whitelisted websites' screen and add link to 'Ad blocking' screen
| Reported by: | annlee@adblockplus.org | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.4.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Currently, users can whitelist a specific website by checking 'Block Ads on this Site' from the Menu, but there's no way for them to then see which sites they whitelisted, or make changes to this. This should be added.
What to change
Add the text 'Whitelisted websites' to the 'Ad blocking' screen - i.e. Menu > Settings > Ad blocking > Whitelisted websites
Create the 'Whitelisted websites' screen, as seen in this mockup
Add the title text, 'Whitelisted websites' at the top
The sites that the user has already whitelisted should appear next (below the title), as seen in this mockup
Add the text 'Add other websites to whitelist' and arrow to the right, as seen in this mockup
Create the 'Add website to whitelist' screen, as seen in this mockup
Add text 'VIA URL / LINK' at the top
Add a grey line underneath
Add a white text box, with blue border and www.yourURL.com in light grey font inside
Add a light blue box underneath, with text 'Add website to whitelist' in white
Attachments (0)
Change History (10)
comment:1 Changed on 07/20/2015 at 07:22:53 AM by philll
comment:2 Changed on 09/08/2015 at 08:37:28 AM by philll
- Sensitive unset
comment:3 Changed on 02/22/2017 at 02:36:21 PM by diegocarloslima
- Owner changed from rjeschke to diegocarloslima
comment:4 Changed on 08/15/2017 at 12:03:02 PM by diegocarloslima
- Priority changed from Unknown to P3
comment:5 Changed on 09/14/2017 at 05:54:31 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/26/2017 at 02:44:14 PM by diegocarloslima
- Milestone Adblock-Browser-for-Android-next deleted
comment:7 Changed on 12/12/2017 at 02:39:29 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Ready set
comment:8 Changed on 01/04/2018 at 10:09:19 PM by abpbot
A commit referencing this issue has landed:
Issue 2801 - Create 'Whitelisted websites' screen and add link to 'Ad blocking' screen
comment:9 Changed on 01/04/2018 at 10:10:49 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 06/05/2018 at 09:53:30 PM by traynard
- Verified working set
Please note that we only allow domains to be whitelisted there, so the label "VIA URL / LINK" is leading to confusion, as you can see in #1745 for example.
Why does this issue have to be confidential?