Opened on 07/17/2015 at 05:37:58 PM
Closed on 06/08/2016 at 04:10:07 PM
#2802 closed change (fixed)
Dynamically generate tooltips
Reported by: | greiner | Assignee: | greiner |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | User-Interface | Keywords: | 2016q1 |
Cc: | Blocked By: | #2356, #2668 | |
Blocking: | #2355 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by greiner)
Background
We implemented the basic tooltip functionality and design for the new options page in #2356. That is enough for adding tooltips to "read more" links on the page but to add tooltips to recommended subscriptions we need to make the tooltip generation more flexible. However, for that we need to have translated descriptions for each of those subscriptions (see #2668).
What to change
- Use <template> to define a tooltip template based on the HTML structure created in #2356
- Mark elements with data-tooltip
- The data-tooltip value represents the ID used for finding the translated texts and the image - if there is one
- Create a function to dynamically create tooltips for a set of given elements
- Call that function on page load for elements matching the [data-tooltip] selector
- Make sure to call that function whenever elements were added to the page that should have a tooltip
- For recommended subscription the data-tooltip value should be taken from subscriptions.xml (see #2668)
- For anchor tags in the "Tweaks" section of the Advanced tab the data-tooltip attribute should be added to the tag
Attachments (0)
Change History (8)
comment:2 Changed on 09/02/2015 at 04:20:38 PM by greiner
- Ready set
comment:3 Changed on 10/13/2015 at 12:08:49 PM by greiner
- Priority changed from Unknown to P3
comment:4 Changed on 01/14/2016 at 06:59:31 PM by greiner
- Owner set to greiner
comment:5 Changed on 01/19/2016 at 06:29:04 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 02/01/2016 at 04:22:41 PM by sebastian
- Keywords 2016q1 added
comment:7 Changed on 06/08/2016 at 04:09:07 PM by abpbot
comment:8 Changed on 06/08/2016 at 04:10:07 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 2802/2358 - Dynamically generate tooltips in options page