Opened on 07/22/2015 at 12:03:27 PM

Closed on 12/04/2015 at 01:39:53 PM

#2809 closed defect (fixed)

Issue reporter is broken in E10S mode

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29331914/

Description

Environment

Adblock Plus 2.6.9.3964
Firefox 42.0a1
"Enable multi-process Nightly" checked in Firefox Preferences

How to reproduce

  1. Go to https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/
  2. Click ABP icon and choose Report issue on this page

Observed behaviour

Issue reporter hangs on the data collection step, Browser Console says: "TypeError: Argument 1 of CanvasRenderingContext2D.drawWindow does not implement interface Window."

Expected behaviour

Data collection should complete.

Attachments (0)

Change History (5)

comment:1 Changed on 08/10/2015 at 12:58:06 PM by trev

  • Keywords e10s added

comment:2 Changed on 12/02/2015 at 12:03:42 PM by trev

  • Priority changed from P1 to P3

Adjusting priority to reality, we aren't fixing this for the next release - but we should take care of it afterwards.

comment:3 Changed on 12/04/2015 at 01:20:10 PM by trev

  • Owner set to trev

comment:4 Changed on 12/04/2015 at 01:21:56 PM by trev

  • Review URL(s) modified (diff)

Put a simple change under review - this one will make sure that Issue Reporter isn't completely broken, and it is safe to be taken for the next release. More thorough fix will follow after the release.

comment:5 Changed on 12/04/2015 at 01:39:53 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

Pushed: https://hg.adblockplus.org/adblockplus/rev/a501d0b59040

Resolving this issue as fixed given that Issue Reporter is no longer broken. Created #3375 as a follow-up, this should actually fix creating screenshots.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.