Opened on 12/04/2015 at 01:38:54 PM
Closed on 01/08/2016 at 04:30:20 PM
Last modified on 01/18/2016 at 01:56:02 AM
#3375 closed defect (fixed)
Issue reporter doesn't create a screenshot in E10S mode
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s |
| Cc: | Blocked By: | ||
| Blocking: | #3486 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
This is a follow-up issue to #2809.
Environment
Adblock Plus 2.6.13.4089-beta
Firefox 45.0a1
"Enable multi-process Nightly" checked in Firefox Preferences
How to reproduce
- Go to https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/
- Click ABP icon and choose Report issue on this page
- Select "Adblock Plus doesn't block an advertisement" and click "Continue"
Observed behaviour
No screenshot of the page is being displayed.
Expected behaviour
A screenshot of the page is displayed so that one can mark the problem there.
Background
canvas.drawWindow() won't accept an CPOW as window parameter. In the multi-process scenario our code isn't running in the same process as the content window so a CPOW is all we've got.
What to change
Move screenshot creation into the content process.
Attachments (0)
Change History (6)
comment:1 Changed on 12/04/2015 at 01:39:18 PM by trev
- Keywords e10s added
comment:2 Changed on 01/07/2016 at 02:31:09 PM by trev
- Owner set to trev
comment:3 Changed on 01/07/2016 at 05:03:12 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 01/07/2016 at 05:07:39 PM by trev
- Blocking 3486 added
comment:5 Changed on 01/08/2016 at 04:30:20 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 01/18/2016 at 01:56:02 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Issue reporter screenshots are working in E10S Firefox's.
ABP 2.7.0.4128-beta
Firefox 45 / 46.0a1 / Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplus/rev/4c2712fa1f4e