#2823 closed change (fixed)

Display new subscription types on adblockplus.org/subscriptions

Reported by:	greiner	Assignee:	greiner
Priority:	P3	Milestone:
Module:	Websites	Keywords:
Cc:		Blocked By:
Blocking:	#1736, #2821	Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29326068/ https://codereview.adblockplus.org/29326085/

Description

Background

In #2822 we will add new subscription types to sitescripts. This allows us to distinguish between certain types of subscriptions which we can use to group subscriptions on adblockplus.org/subscriptions.

What to change

Add the following headline texts to locales/en/subscriptions.json
- anti-adblock: Anti ad blocking
- malware: Malware protection
- privacy: Privacy protection
- social: Social media blocking
Set table width to 100%
Add a Table of Contents by adding "id" attributes to <h2> tags
Make sure that subscriptions end up under the appropriate headline - this also applies for supplements in which case they shouldn't be indented

Change History (8)

comment:1 Changed on 09/07/2015 at 10:12:26 AM by greiner

See #2994

comment:2 Changed on 09/07/2015 at 10:17:50 AM by saroyanm

Priority changed from Unknown to P3
Ready set

comment:3 Changed on 09/07/2015 at 02:08:31 PM by philll

comment:4 Changed on 09/07/2015 at 02:53:24 PM by greiner

Blocking 1736 added

comment:5 Changed on 09/07/2015 at 06:26:30 PM by greiner

Owner set to greiner

comment:6 Changed on 09/08/2015 at 10:20:56 AM by greiner

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:7 Changed on 09/09/2015 at 12:14:29 PM by greiner

Sitescripts changes: https://hg.adblockplus.org/sitescripts/rev/f61096689ee8

comment:8 Changed on 09/18/2015 at 09:26:39 AM by greiner

Resolution set to fixed
Status changed from reviewing to closed

web.adblockplus.org changes: https://hg.adblockplus.org/web.adblockplus.org/rev/eb992c364e3c

Context Navigation

#2823 closed change (fixed)

Display new subscription types on adblockplus.org/subscriptions

Description

Background

What to change

Attachments (0)

Change History (8)

comment:1 Changed on 09/07/2015 at 10:12:26 AM by greiner

comment:2 Changed on 09/07/2015 at 10:17:50 AM by saroyanm

comment:3 Changed on 09/07/2015 at 02:08:31 PM by philll

comment:4 Changed on 09/07/2015 at 02:53:24 PM by greiner

comment:5 Changed on 09/07/2015 at 06:26:30 PM by greiner

comment:6 Changed on 09/08/2015 at 10:20:56 AM by greiner

comment:7 Changed on 09/09/2015 at 12:14:29 PM by greiner

comment:8 Changed on 09/18/2015 at 09:26:39 AM by greiner

Add Comment

Modify Ticket

Changed by kzar

Download in other formats:

Summary:
Description:	You may use WikiFormatting here. === Background === In #2822 we will add new subscription types to sitescripts. This allows us to distinguish between certain types of subscriptions which we can use to group subscriptions on adblockplus.org/subscriptions. === What to change === - Add the following headline texts to `locales/en/subscriptions.json` - anti-adblock: Anti ad blocking - malware: Malware protection - privacy: Privacy protection - social: Social media blocking - Set table width to `100%` - Add a Table of Contents by adding "id" attributes to `<h2>` tags - Make sure that subscriptions end up under the appropriate headline - this also applies for supplements in which case they shouldn't be indented
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29326068/ https://codereview.adblockplus.org/29326085/