Opened on 07/27/2015 at 07:15:20 PM
Closed on 10/04/2017 at 03:10:25 PM
#2825 closed change (fixed)
Use new subscription types in subscriptionlist
| Reported by: | greiner | Assignee: | arthur |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | saroyanm, ferris, subscriptionlist@adblockplus.org | Blocked By: | #2821 |
| Blocking: | #1736, #2706, #5158, #5803 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by saroyanm)
Background
We need to distinguish between different subscription types in the new options page. For that we added support for new types in #2821 and make use of those now.
What to change
Change the types of the following subscriptions in the subscriptionlist repository:
- anti-adblock
- Adblock Warning Removal List
- malware
- Adware filters
- Malware Domains
- Spam404
- privacy
- EasyPrivacy
- social
- Fanboy's Social Blocking List
Add the "recommended" flag to the following subscriptions in the subscriptionlist repository:
- EasyPrivacy
- Fanboy's Social Blocking List
Attachments (0)
Change History (17)
comment:2 Changed on 09/25/2015 at 05:15:21 PM by greiner
- Blocking 1736 added
comment:3 Changed on 10/08/2015 at 11:55:32 AM by greiner
- Component changed from Unknown to Infrastructure
comment:5 Changed on 01/24/2017 at 11:59:34 AM by saroyanm
- Cc saroyanm added
comment:6 follow-up: ↓ 8 Changed on 02/09/2017 at 09:19:39 AM by ferris
@greiner @saroyanm Can you please outline what needs to be done in the backend/infrastructure for this to happen?
comment:7 Changed on 02/09/2017 at 02:00:25 PM by saroyanm
It's about changing types of the mentioned filters in subscriptionlist repository, currently all of them in the repository has "other" as a type. ex.: Malware Domains repository should be marked as "malware" instead of "other".
Updated: And also adding a recommended flag, to the mentioned ones.
comment:8 in reply to: ↑ 6 Changed on 02/09/2017 at 02:01:39 PM by saroyanm
- Cc ferris added
Replying to ferris:
@ferris: ^
comment:10 Changed on 02/09/2017 at 02:46:08 PM by ferris
- Cc subscriptionlist@adblockplus.org added
OK, thanks. I don't have access to push anything in those repositories. I'll try adding subscriptionlist@adblockplus.org to cc and see what happens :)
comment:11 Changed on 02/09/2017 at 03:04:19 PM by saroyanm
Note: This ticket is blocked by another one still.
comment:12 Changed on 05/10/2017 at 03:06:23 PM by greiner
- Description modified (diff)
We're not going to recommend the "Malware Domains" filter list as part of our new options page so there's no need to mark it as "recommended" at this point. I updated the ticket description accordingly.
comment:13 Changed on 08/17/2017 at 03:01:27 PM by saroyanm
- Description modified (diff)
Updated accordingly as we are going to only "recommend" EasyPrivacy and Fanboy's Social Blocking List on the new options page's General Tab.
comment:14 Changed on 09/28/2017 at 01:24:30 PM by saroyanm
- Blocking 5158 added
comment:15 Changed on 09/28/2017 at 01:40:09 PM by saroyanm
- Blocking 5803 added
comment:16 Changed on 10/04/2017 at 03:07:40 PM by arthur
- Owner set to arthur
comment:17 Changed on 10/04/2017 at 03:10:25 PM by arthur
- Resolution set to fixed
- Status changed from new to closed
Updated list.