Opened on 07/28/2015 at 11:54:35 AM

Closed on 07/28/2015 at 06:21:23 PM

Last modified on 09/16/2015 at 04:52:36 PM

#2832 closed defect (fixed)

Findbar slightly broken in Firefox 42

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.6.11-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29322851/

Description

Environment

Firefox 42.0a1 nightly (2015-07-24)
Adblock Plus 2.6.10
Mac OS X 10.10

How to reproduce

  1. Open Filter Preferences
  2. Click Find
  3. Type "nosuchfilter"

Observed behaviour

Error message "TypeError: this._browser.messageManager is undefined" in Browser Console and no indicator that filter wasn't found.

Expected behaviour

No error message and text "phrase wasn't found" being displayed in the findbar.

Attachments (0)

Change History (5)

comment:1 Changed on 07/28/2015 at 12:35:12 PM by trev

  • Owner set to trev

comment:2 Changed on 07/28/2015 at 12:37:31 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/28/2015 at 06:21:23 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/a4ae1a0386a0

comment:4 Changed on 09/16/2015 at 04:52:27 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

comment:5 Changed on 09/16/2015 at 04:52:36 PM by sebastian

  • Milestone changed from Adblock-Plus-for-Chrome-Opera-Safari-next to Adblock-Plus-for-Firefox-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.