Opened on 08/07/2015 at 05:50:03 AM

Closed on 08/07/2015 at 07:08:07 PM

#2868 closed defect (fixed)

Pull processes piling up after deploying the new notification handler

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: matze Blocked By:
Blocking: #2162 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29323363/

Description

How to reproduce

  1. Deploy #2277 on an active filter server.

Observed behaviour

During cache warm up, a large number of hg pull processes is piling up, blocked on network I/O. On a single core server, that alone causes the load to skyrocket. On a multi core server, it is still severely straining hg.adblockplus.org.

Expected behaviour

hg pull of the notifications repository shouldn't happen for every single (cache miss) request.

Attachments (0)

Change History (5)

comment:1 Changed on 08/07/2015 at 05:50:15 AM by fhd

  • Owner set to fhd

comment:2 Changed on 08/07/2015 at 06:20:42 AM by fhd

  • Blocked By 2869 added

comment:3 Changed on 08/07/2015 at 06:39:23 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/07/2015 at 07:08:50 AM by fhd

  • Blocking 2162 added

comment:5 Changed on 08/07/2015 at 07:08:07 PM by fhd

  • Blocked By 2869 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/sitescripts/rev/4fa30d749f19

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.