Opened on 04/10/2014 at 01:40:02 PM

Closed on 04/10/2014 at 05:11:05 PM

Last modified on 03/02/2015 at 02:31:20 PM

#296 closed change (fixed)

[libadblockplus] Don't require custom build step to eliminate thin archives

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5637716494516224/

Description

Background

Currently there is a fairly non-obvious and undocumented build step required to make V8 libraries reusable - one has to convert thin archives into regular archives.

What to change

Inject standalone_static_library flag into V8 configuration to make sure no thin archives are created in the first place.

Attachments (0)

Change History (4)

comment:1 Changed on 04/10/2014 at 01:43:19 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/10/2014 at 05:11:05 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed on 04/13/2014 at 06:35:01 PM by trev

  • Milestone set to Adblock-Plus-for-Android-next

comment:4 Changed on 03/02/2015 at 02:31:20 PM by rjeschke

  • Milestone Adblock-Plus-for-Android-1.3 deleted
  • Platform set to Unknown

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.