Opened on 04/10/2014 at 02:45:23 PM

Closed on 04/10/2014 at 05:11:29 PM

Last modified on 03/02/2015 at 02:30:34 PM

#297 closed defect (fixed)

Libadblockplus builds broken on OS X

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4892505308921856

Description

Environment

OS X 10.9

How to reproduce

  1. Run make android

Observed behaviour

Compiler complains about -arch i386 flag it cannot recognize.

Expected behaviour

Libadblockplus should complile.

Analysis

gyp mistakenly classifies the build target as OS X and tries to do some XCode-related mangling.

Attachments (0)

Change History (4)

comment:1 Changed on 04/10/2014 at 02:47:48 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/10/2014 at 05:11:29 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/libadblockplus/rev/7b6a11454953

comment:3 Changed on 04/13/2014 at 06:35:01 PM by trev

  • Milestone set to Adblock-Plus-for-Android-next

comment:4 Changed on 03/02/2015 at 02:30:34 PM by rjeschke

  • Milestone Adblock-Plus-for-Android-1.3 deleted
  • Platform set to Unknown

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.