Opened on 09/02/2015 at 10:25:34 AM

Closed on 10/16/2015 at 07:38:58 AM

Last modified on 12/15/2016 at 06:16:19 AM

#2975 closed defect (fixed)

[ABP for IE] [Settings page] Missing space after colons

Reported by: passbrains Assignee:
Priority: Unknown Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, greiner Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Rraceanu Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29329035/

Description (last modified by Shikitita)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-116

Environment

Windows 8.1 + IE11
ABP version 1.4.796

How to reproduce

  1. Load IE browser
  2. Click on ABP icon at the bottom right of the screen
  3. Click on Settings

Observed behaviour

There are missing spaces after the colons:

"Language:Select [...]"
"Manage Blocking:You can disable [...]"

Expected behaviour

There should be a space after each colon

Attachments (2)

2315_1438628283_2015-08-03_21-36-17.png (187.5 KB) - added by passbrains on 09/02/2015 at 10:25:38 AM.
English_Settings_MissingSpace.jpg (277.7 KB) - added by Shikitita on 09/02/2015 at 10:54:45 AM.

Download all attachments as: .zip

Change History (8)

Changed on 09/02/2015 at 10:25:38 AM by passbrains

comment:1 Changed on 09/02/2015 at 10:40:16 AM by Shikitita

  • Description modified (diff)
  • Summary changed from Settings page - There are no space between words in Ukrainian to [ABP for IE] [Settings page] Missing space after colons

Please note that, by what I can see in Crowdin, this seems to be an issue with the source language and which therefore affects every single translation.

Changed on 09/02/2015 at 10:54:45 AM by Shikitita

comment:2 Changed on 09/03/2015 at 10:53:11 AM by greiner

  • Cc oleksandr greiner added
  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer

The problem is that there's simply no space between those two elements in the HTML code. It has nothing to do with the texts.

comment:3 Changed on 10/12/2015 at 10:09:18 AM by sergz

  • Review URL(s) modified (diff)

comment:4 Changed on 10/16/2015 at 07:38:58 AM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed on 11/21/2016 at 10:44:31 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:6 Changed on 12/15/2016 at 04:16:07 AM by rraceanu

  • Tester changed from Unknown to Rraceanu
  • Verified working set

Change successfully implemented, verified on IE 10 Windows 8.1, IE 11 Windows 10, ABP version 1.5.856.

Last edited on 12/15/2016 at 06:16:19 AM by rraceanu

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.