Opened on 09/02/2015 at 10:17:12 AM
Last modified on 03/14/2017 at 03:39:33 PM
#2974 reviewing change
Integrate class web::server with Hiera
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | fhd, fred | Blocked By: | #2979 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29325553 |
||
Description
Nodes that are setup based on Puppet class web::server are still classified in hard-coded fashion (manifests/webserver.pp). In order to proceed with the Hiera migration and to allow for more flexibility when operating module web, those need to become integrated as Hiera roles (hiera/roles/*.yaml).
Caveats
While the nodes web3, web-sh-abp-org-1, web-yt-abp-me-1, web-fb-abp-me-1 and web-aa-org-1 are pretty straightforward setups easy to migrate, the remaining ones (web1 and web2) are not that trivial. Beside the classes web::server and statsclient, those also feature additional resource definitions. Thus it may become necessary to create individual classes based on web::server for these nodes.
Since #2965, in which context another web::server node has to be setup, is currently waiting for #2899, this is probably a good chance to perform the migration right now - simply because these tickets will include QA testing anyway, so that we can test two scopes at once here.
Note that something like this is not always a good idea, simply because it may become difficult to determine the cause of issues arising. However, in this case the change-set in Puppet is so trivial that such risk is almost absent.