Opened on 03/08/2014 at 07:59:07 AM

Closed on 03/17/2014 at 11:44:10 AM

Last modified on 04/13/2014 at 06:28:30 PM

#3 closed defect (fixed)

Unused icon sizes being packaged for Chrome/Safari builds

Reported by: trev Assignee: saroyanm
Priority: P4 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords: goodfirstbug
Cc: Blocked By:
Blocking: #4 Platform:
Ready: Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Right now our Chrome builds include the following unused icons:

icons/abp-16.png
icons/abp-16-notification-critical.png
icons/abp-16-notification-information.png

Similarly, Safari builds include the following unused icons:

icons/abp-19.png
icons/abp-19-notification-critical.png
icons/abp-19-notification-information.png

These icons need to be moved to platform-specific directories and only added for the platforms that need them.

Attachments (0)

Change History (9)

comment:1 Changed on 03/08/2014 at 08:09:58 AM by trev

  • Blocking 4 added

comment:2 Changed on 03/08/2014 at 08:14:09 AM by trev

  • Keywords goodfirstbug added

comment:3 Changed on 03/13/2014 at 07:38:41 AM by saroyanm

  • Owner set to saroyanm
  • Status changed from new to assigned

comment:4 Changed on 03/13/2014 at 03:42:50 PM by saroyanm

  • Status changed from assigned to reviewing

comment:5 Changed on 03/13/2014 at 03:43:59 PM by saroyanm

Code Review link : ​http://codereview.adblockplus.org/5709671373471744/

comment:6 Changed on 03/14/2014 at 02:09:43 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 03/17/2014 at 11:07:28 AM by saroyanm

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 Changed on 03/17/2014 at 11:44:10 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:9 Changed on 04/13/2014 at 06:28:30 PM by trev

  • Component changed from Adblock-Plus-for-Firefox to Platform
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.