Opened on 03/08/2014 at 08:09:58 AM
Closed on 04/03/2014 at 11:51:15 AM
Last modified on 02/06/2018 at 02:35:27 PM
#4 closed change (fixed)
Add high-DPI versions of Chrome/Safari icons
| Reported by: | trev | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sven | Blocked By: | #3 |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5838171610808320/ |
||
Description (last modified by trev)
Both Chrome and Safari allow adding high-DPI icons for Retina displays - 38x38 for Chrome and 32x32 for Safari. The agreement here is that we are going with a larger version of the current icon for now, without any additional details.
Attachments (2)
Change History (15)
comment:1 Changed on 03/10/2014 at 02:21:57 PM by sven
Changed on 03/11/2014 at 12:50:12 PM by sven
Changed on 03/11/2014 at 12:50:26 PM by sven
comment:3 follow-up: ↓ 4 Changed on 03/19/2014 at 04:22:12 PM by philll
- Cc sven added
- in_progress set to 0
- Ready unset
@sven: Which of those attachments shall be used? Please specify in the description eg by linking to the desired one.
comment:4 in reply to: ↑ 3 Changed on 03/19/2014 at 04:57:24 PM by philll
Replying to philll:
@sven: Which of those attachments shall be used? Please specify in the description eg by linking to the desired one.
Removed the unnecessary attachments as demanded by sven. Still I recommend to be the description explicit better than implicit and link to the respective attachment where they should be referenced.
comment:5 Changed on 04/02/2014 at 03:18:29 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 04/02/2014 at 04:38:09 PM by trev
- Status changed from reviewing to reopened
comment:7 Changed on 04/02/2014 at 04:38:23 PM by trev
- Owner set to sebastian
- Status changed from reopened to assigned
comment:8 Changed on 04/02/2014 at 04:38:31 PM by trev
- Status changed from assigned to reviewing
comment:9 Changed on 04/03/2014 at 11:51:15 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 04/04/2014 at 11:00:12 AM by sebastian
- Review URL(s) modified (diff)
comment:11 Changed on 04/13/2014 at 06:28:30 PM by trev
- Component changed from Adblock-Plus-for-Firefox to Platform
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
comment:12 Changed on 05/16/2014 at 01:44:13 PM by sebastian
- Ready set
comment:13 Changed on 02/06/2018 at 02:35:27 PM by abpbot
A commit referencing this issue has landed:
GitLab Issue 4 - Update navigation menus
32x32 and 38x38 icons are attached.