Opened on 04/11/2014 at 05:49:47 AM
Closed on 05/08/2014 at 02:37:41 PM
Last modified on 07/15/2014 at 10:14:38 AM
#301 closed change (fixed)
Replace for each loops by for of loops
| Reported by: | tschuster | Assignee: | tschuster |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, thomas@adblockplus.org | Blocked By: | #764 |
| Blocking: | #312 | Platform: | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/6341149593698304/ |
||
Description
Background
We are currently using for each loops extensively. This JavaScript feature is Mozilla-only and deprecated however.
What to change
Use for...of loops, these have the same functionality but are standardized. They are supported starting with Firefox 13 which is good enough for us.
Attachments (0)
Change History (12)
comment:1 Changed on 04/11/2014 at 05:50:29 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/11/2014 at 11:01:23 PM by tschuster
comment:3 Changed on 04/12/2014 at 07:42:15 AM by trev
- Cc trev added
- Owner set to tschuster
- Reporter changed from trev to tschuster
- Status changed from reviewing to assigned
comment:4 Changed on 04/12/2014 at 12:22:39 PM by tschuster
- Blocking 312 added
comment:6 Changed on 04/14/2014 at 11:41:16 AM by greiner
- Cc thomas@adblockplus.org added
comment:7 Changed on 04/14/2014 at 06:03:32 PM by tschuster
comment:8 Changed on 04/14/2014 at 09:17:40 PM by trev
I realized that we are also converting a few for each loops in libadblockplus. I am addressing this as part of my changes in #189.
comment:9 Changed on 04/15/2014 at 07:03:39 AM by trev
Same goes for the adblockpluschrome repository, also addressing this in #189.
comment:10 Changed on 04/30/2014 at 09:50:33 AM by philll
- Status changed from assigned to new
The assigned state will be dropped by #403
comment:11 Changed on 05/08/2014 at 02:37:41 PM by trev
- Milestone set to Adblock-Plus-2.6-for-Firefox
- Resolution set to fixed
- Status changed from new to closed
comment:12 Changed on 07/15/2014 at 10:14:38 AM by trev
- Blocked By 764 added
I the person working on this, I think I can't assign this to myself.