Opened on 03/21/2014 at 05:45:19 PM
Closed on 04/24/2014 at 11:27:18 AM
Last modified on 05/02/2014 at 05:36:05 AM
#189 closed change (fixed)
Implement API changes from #117, #153, #192 in Chrome and libadblockplus
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #117, #153, #192 | |
| Blocking: | #204 | Platform: | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/6658724257071104/ |
||
Description (last modified by trev)
Background
#117, #153 and #192 implemented some changes to our core APIs. #117 introduced Utils.yield(). #153 removed the fallback to defaults/patterns.ini when there is no patterns.ini file, instead FilterStorage.firstRun flag was introduced. #192 removed encode and decode parameters from FilterStorage.readFromFile() and FilterStorage.writeFromFile().
What to change
Implement Utils.yield() as an empty function. Also, remove the hack looking for the fallback URL to be read, check FilterStorage.firstRun instead.
Attachments (0)
Change History (16)
comment:1 Changed on 03/22/2014 at 09:06:41 AM by trev
- Summary changed from Implement API changes from #117 and #153 in Chrome to Implement API changes from #117 and #153 in Chrome and libadblockplus
comment:3 Changed on 03/23/2014 at 12:49:40 PM by trev
I am inclined to back out the change above because it really doesn't solve anything - it merely makes it look like things are working (see #191 which was resolved as "fixed"). In order for the Chrome (and libadblockplus) code to work correctly given the recent changes some more work needs to be done. Until then we should not update the adblockplus subrepository there.
comment:4 Changed on 03/24/2014 at 01:37:58 PM by trev
- Blocking 204 added
comment:5 Changed on 04/09/2014 at 10:25:12 AM by sebastian
Please remove the workaround added by http://codereview.adblockplus.org/5118635873927168/ when this is fixed and the adblockplus subrepo is updated within the adblockpluschrome repository.
comment:6 Changed on 04/14/2014 at 07:02:58 AM by trev
- Owner set to trev
- Status changed from new to assigned
comment:9 Changed on 04/14/2014 at 10:15:58 AM by trev
- Blocked By 117, 153, 192 added
- Summary changed from Implement API changes from #117 and #153 in Chrome and libadblockplus to Implement API changes from #117, #153, #192 in Chrome and libadblockplus
comment:10 Changed on 04/14/2014 at 09:14:55 PM by trev
- Review URL(s) modified (diff)
- Status changed from assigned to reviewing
comment:11 Changed on 04/15/2014 at 01:40:46 PM by trev
Chrome changes landed: https://hg.adblockplus.org/adblockpluschrome/rev/26f20cc028c9
comment:12 Changed on 04/15/2014 at 01:46:18 PM by trev
- Review URL(s) modified (diff)
comment:13 Changed on 04/15/2014 at 01:59:38 PM by trev
Removed hack mentioned in comment 5: https://hg.adblockplus.org/adblockpluschrome/rev/f90743616c19
comment:14 Changed on 04/24/2014 at 11:27:18 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Libadblockplus changes landed: https://hg.adblockplus.org/libadblockplus/rev/1ae1b8d23f10
comment:15 Changed on 04/24/2014 at 11:33:10 AM by trev
Updated libadblockplus-binaries repository as well: https://hg.adblockplus.org/libadblockplus-binaries/rev/7b68c61243c5
comment:16 Changed on 05/02/2014 at 05:36:05 AM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Added empty Utils.yield implementation (also see #191)
https://hg.adblockplus.org/adblockpluschrome/rev/516c7018cc9c