Opened on 09/08/2015 at 04:14:08 PM
Closed on 09/10/2015 at 02:44:30 PM
Last modified on 09/17/2015 at 06:28:02 PM
#3022 closed change (fixed)
Add new notification type for normal messages
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.9.3-for-Chrome-Opera-Safari-next |
| Module: | Platform | Keywords: | |
| Cc: | fhd, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by greiner)
Background
When first testing the notification mechanism for promoting Adblock Browser we found out that, on Chrome, most people were noticing that notification either not at all or only days later. Therefore we want to introduce a new notification type for normal (i.e. low-severity) messages.
What to change
"normal"-type notifications should
- trigger a desktop notification
- not cause the icon to animate
- not show up in the icon popup
- apart from the points above behave like "information"-type notifications
What to test
You could set up a local static server which provides a JSON file containing a single notification of a specific type. You could then replace "https://notification.adblockplus.org/notification.json" in lib/prefs.js with the address to that JSON file and re-/install the extension to automatically trigger the request with a short delay to show the expected notification.
The expected behavior is as follows:
- type=critical:
- Animate icon with its "!"-variant.
- Show red notification in icon popup.
- Show a desktop notification.
- type=normal:
- Show a desktop notification.
- type=information:
- Animate icon with its "?"-variant.
- Show a blue notification in icon popup.
- type=(other):
- Show a black notification in icon popup.
- No type:
- Show a black notification in icon popup.
To test notifications of type "question" you can just browse to http://wwwok.at which should trigger a desktop notification.
Attachments (0)
Change History (8)
comment:1 Changed on 09/08/2015 at 04:16:56 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 09/09/2015 at 01:20:35 PM by greiner
- Owner set to greiner
comment:3 Changed on 09/09/2015 at 01:20:54 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 09/10/2015 at 02:44:30 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 09/11/2015 at 06:48:44 PM by greiner
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
comment:7 Changed on 09/17/2015 at 03:01:29 AM by Ross
Just noting that I've mostly tested this in Chrome/Opera and the new notification type (and previous) ones are behaving as described/correctly. Safari to do.
comment:8 Changed on 09/17/2015 at 06:28:02 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Normal type of notification works as described.
ABP 2.6.0.3979-beta
Firefox 40.0.3 / Windows 7 - 32bit
Firefox 40.0.3 / Ubuntu 14.04 - 64bit
ABP 1.9.2.1482
Chrome 45.0.2454.93 m / Windows 7 - 32bit
Chrome 45.0.2454.93 m / OS X 10.9
Opera 32.0.1948.25 / Windows 7 - 32bit
Safari 7.0.6 / OS X 10.9
https://hg.adblockplus.org/adblockpluschrome/rev/9b1fd7701242