Opened on 09/23/2015 at 08:48:49 AM
Closed on 09/30/2015 at 01:17:46 PM
Last modified on 11/04/2015 at 10:41:51 AM
#3110 closed defect (fixed)
[Adblock Browser for iOS] Acceptable Ads blocked in Yelp website
| Reported by: | Shikitita | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Browser-for-iOS-1.2.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | pavelz, vojtab, jand, Shikitita | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Platform: iPhone 5s
Operating system: iOS 8.4
Browser: Adblock Browser for iOS v. 1.1.0 (476)
How to reproduce
- Install and launch Adblock Browser
- Tap on the URL Search bar at the top of the screen in order to enter the following link: http://www.yelp.com/search?find_desc=tacos&find_loc=San+Francisco%2C+CA%2C+USA&ns=1
- Disable ABP in the browser tapping on the icon displayed in the middle at the bottom of the screen and then unchecking "Ad blocking on this site"
- Refresh the website by tapping on the refresh icon displayed inside the URL Search bar on the right side
Observed behaviour
There are no ads displayed when ABP is enabled in the browser. An attempt to display them can be seen when loading the link for the first time with Acceptable Ads and ABP enabled.
Expected behaviour
Acceptable Ads shouldn't be blocked even if ABP is enabled. The correct behaviour can be observed when checking the same link with Google Chrome.
Attachments (1)
Change History (5)
Changed on 09/23/2015 at 08:49:53 AM by Shikitita
comment:1 Changed on 09/23/2015 at 12:36:03 PM by pavelz
An attempt to display them can be seen when loading the link for the first time with Acceptable Ads and ABP enabled
This observation is absolutely correct. The Ad offers are there, it's not blocked, just hidden by CSS. The AA is not in subframe, so the main frame is getting wrong CSS.
comment:2 Changed on 09/30/2015 at 01:17:20 PM by pavelz
https://www.pivotaltracker.com/story/show/104528670
Background script was getting a sender frame with Referer form of URL, ie. compatible with WebKit Referer headers - no query part. The whitelist filter is expecting a complete URL, therefore didn't match. Yelp specifically wants to find the questionmark which is opening the query part.
comment:3 Changed on 09/30/2015 at 01:17:46 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 11/04/2015 at 10:41:51 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
Acceptable Ad displayed with "Ad blocking on this site" disabled