Opened on 09/24/2015 at 10:09:40 AM
Closed on 01/25/2016 at 10:18:16 AM
#3117 closed change (fixed)
Restrict "prefixes" attribute in recommendations.xml to subscriptions that specify languages
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | goodfirstbug |
| Cc: | kzar | Blocked By: | |
| Blocking: | #2821 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Both subscriptions.xml and subscriptions2.xml templates include a condition that ensures that the "prefixes" attribute is only added to <subscription> if the subscription specifies at least one language. So far recommendations.xml didn't need this condition since all recommended subscriptions do specify languages. But with the introduction of non-"ads" type subscriptions to that list in #2825 this will change. Therefore we need to add this condition to recommendations.xml.
What to change
Ensure to only include prefixes="{{subscription.languages}}" in the template for recommendations.xml for subscriptions that specify languages. The resulting recommendations.xml shouldn't differ from the current one.
Attachments (0)
Change History (4)
comment:1 Changed on 10/20/2015 at 11:41:32 AM by kzar
- Cc kzar added
- Keywords goodfirstbug added
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 01/20/2016 at 12:16:01 PM by greiner
- Owner set to greiner
comment:3 Changed on 01/20/2016 at 12:24:24 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 01/25/2016 at 10:18:16 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/sitescripts/rev/4383a7c9f0a4