Opened on 09/25/2015 at 09:56:57 AM

Closed on 09/25/2015 at 11:58:17 AM

#3124 closed change (fixed)

Allow the new severity value "normal"

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #3125 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29328652/

Description

Background

#3022 added a new notification severity, normal, but the notification parser only allows information or emergency.

What to change

Allow the normal severity in the notification parser.

Attachments (0)

Change History (4)

comment:1 Changed on 09/25/2015 at 10:07:55 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/25/2015 at 10:19:42 AM by fhd

  • Blocking 3125 added

comment:3 Changed on 09/25/2015 at 10:52:58 AM by fhd

Had to push this pre-review due to time constraints: ​https://hg.adblockplus.org/sitescripts/rev/c969ce512008

comment:4 Changed on 09/25/2015 at 11:58:17 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Reviewed now.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.