Opened on 09/27/2015 at 01:57:53 PM
Closed on 11/09/2015 at 03:04:47 PM
Last modified on 11/16/2015 at 11:50:38 AM
#3129 closed defect (fixed)
Rules cannot be edited if "Search for text when I start typing" is enabled
| Reported by: | Ac | Assignee: | trev |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-2.6.12-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | greiner, trev, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29328828/ |
||
Description (last modified by greiner)
Environment
Windows 7 x64
Firefox 41.0
Adblock Plus 2.6.11
No filter list is used
How to reproduce
- Go to Firefox Options -> Advanced -> General and make sure the option "Search for text when I start typing" is switched on
- Get to Adblock Plus and double click any rule to start editing
- Type any character (like "a") and it will go to now opened Findbar to fill it, not to the rule name.
Observed behaviour
While editing a rule the typed characters are filling the Findbar, not the rule name.
Expected behaviour
If you edit the rule what you type should get to the rule name, not Findbar.
This was broken in 2.6.11, version 2.6.10 works fine.
What to change
Make sure that in "filters.xul" #findbar's "_findAsYouType" property is set to false to prevent the findbar from being opened by interactions with the filter tree. This property reflects the value of the accessibility.typeaheadfind preference which is the one behind the "Search for text when I start typing" option.
Attachments (0)
Change History (13)
comment:1 Changed on 09/27/2015 at 02:35:42 PM by mapx
comment:2 Changed on 09/27/2015 at 02:36:32 PM by mapx
- Resolution set to duplicate
- Status changed from new to closed
comment:3 Changed on 09/27/2015 at 06:10:50 PM by Ac
This bug seems different from #2580. It reveals itself only after the last ABP version (2.6.11). So they should not be duplicated, maybe just linked.
comment:4 Changed on 09/28/2015 at 07:39:54 AM by mapx
- Cc greiner trev mapx added
comment:5 Changed on 09/28/2015 at 11:54:31 AM by greiner
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Resolution duplicate deleted
- Status changed from closed to reopened
comment:6 Changed on 09/29/2015 at 10:42:10 AM by greiner
- Description modified (diff)
Added "What to change" section to get this ticket to ready state.
comment:7 Changed on 10/05/2015 at 09:45:37 AM by trev
- Ready set
comment:8 Changed on 10/05/2015 at 10:19:27 AM by greiner
- Owner set to greiner
comment:9 Changed on 10/05/2015 at 11:30:21 AM by greiner
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:10 Changed on 11/06/2015 at 08:31:18 PM by trev
- Owner changed from greiner to trev
comment:11 Changed on 11/06/2015 at 08:31:40 PM by trev
- Review URL(s) modified (diff)
Let's try a different approach.
comment:12 Changed on 11/09/2015 at 03:04:47 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 11/16/2015 at 11:50:38 AM by trev
- Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox
Adblock Plus 2.6.12 is being released from branch, this change is part of it.
see #2580