Opened on 05/23/2015 at 05:00:08 PM
Closed on 10/05/2015 at 02:22:10 PM
Last modified on 11/16/2015 at 11:50:38 AM
#2580 closed defect (fixed)
Attempt to perform 2nd search for filter in ABP for Firefox doesn't select the previous one
| Reported by: | Lain_13 | Assignee: | greiner |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-2.6.12-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | sebastian, trev, mapx, greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Environment
Windows 7, Fx 38.0.1, ABP 2.6.9
How to reproduce
- Open ABP preferences.
- Press Ctrl+F and type something.
- Select something outside of the search field. E.g., any rule in the list.
- Press Ctrl+F again.
Observed behaviour
Focus moves to the search field but text there isn't selected, so if you start typing without pressing directional keys it won't be replaced with the new text.
Expected behaviour
Focus moves to the search field and becomes selected. If you start typing without pressing directional keys old text should disappear. Same as normal search within current page feature in the Firefox.
What to change
Add finder.getInitialSelection() method to the fake browser instance in "filters-search.js". It's sufficient to call onCurrentSelection(null, true) on each result listener to achieve the expected behavior.
Attachments (0)
Change History (12)
comment:1 Changed on 06/16/2015 at 07:39:40 PM by sebastian
- Cc sebastian trev added
- Component changed from Unknown to Adblock-Plus-for-Firefox
comment:2 Changed on 06/16/2015 at 07:50:29 PM by sebastian
comment:3 Changed on 07/30/2015 at 09:10:53 PM by mapx
- Cc mapx added
- Tester set to Unknown
comment:4 Changed on 07/30/2015 at 09:15:28 PM by mapx
I can reproduce the issue in firefox 40 and firefox dev edition 41.0a2 (2015-07-30)
go to custom filters panel
press F2 to edit an existent filter
start typing something ==> the focus moves to search field and from custom filters you'll land into filter subscriptions tab
the same wrong behaviour if:
-copy something from a document for example, go into custom filters tab and paste (using CTRL-V not right click paste) ==> the text will land in the same search field.
comment:5 Changed on 07/30/2015 at 09:16:28 PM by mapx
- Cc greiner added
comment:6 Changed on 09/27/2015 at 02:35:01 PM by mapx
The issue seems to be reproducible when
"Search for text when I start typing" option is enabled
see #3129
comment:7 Changed on 09/29/2015 at 01:57:44 PM by greiner
- Description modified (diff)
Added "What to change" section to get this ticket to ready state.
comment:8 Changed on 10/05/2015 at 09:45:26 AM by trev
- Ready set
comment:9 Changed on 10/05/2015 at 10:18:44 AM by greiner
- Owner set to greiner
comment:10 Changed on 10/05/2015 at 11:29:58 AM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:11 Changed on 10/05/2015 at 02:22:10 PM by greiner
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 11/16/2015 at 11:50:38 AM by trev
- Milestone changed from Adblock-Plus-for-Firefox-next to Adblock-Plus-2.6.12-for-Firefox
Adblock Plus 2.6.12 is being released from branch, this change is part of it.
Reproduced with Firefox (Iceweasel) 38.0.1-5 on Debian Linux and Adblock Plus 2.6.9.1 as well as current devbuild. However, I cannot reproduced it with Firefox 34. So it seems that a change in Firefox is causing this.