Opened on 09/30/2015 at 10:48:45 AM

Closed on 07/08/2016 at 05:05:16 PM

#3141 closed change (fixed)

Add missing favicon and title to acceptableads.org

Reported by: greiner Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: sven, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29346672/

Description (last modified by saroyanm)

Background

When you're on acceptableads.org the tab in the browser tabbar shows the mobile icon and its URL as the tab title. Therefore we should add those to fix this oversight.

What to change

  • Add current icon at https://acceptableads.org/favicon.ico.
  • Add <title> tag with the following text: "Acceptable Ads Manifesto - Encouraging better ads".

Attachments (1)

aa_logo_32x32.png (19.6 KB) - added by sven on 11/30/2015 at 10:56:59 AM.

Download all attachments as: .zip

Change History (6)

comment:1 Changed on 11/26/2015 at 05:46:42 PM by saroyanm

  • Cc saroyanm added

@Sven can you please upload the logo, after that I'll mark as ready and implement.

Changed on 11/30/2015 at 10:56:59 AM by sven

comment:2 Changed on 06/20/2016 at 06:47:44 PM by juliandoucette

  • Owner set to juliandoucette

comment:3 Changed on 06/20/2016 at 06:49:08 PM by juliandoucette

  • Priority changed from Unknown to P3
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 06/21/2016 at 04:54:12 PM by saroyanm

  • Description modified (diff)

comment:5 Changed on 07/08/2016 at 05:05:16 PM by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from juliandoucette.
 
Note: See TracTickets for help on using tickets.