Opened on 10/09/2015 at 08:26:00 AM
Closed on 09/07/2017 at 07:43:12 PM
#3183 closed defect (fixed)
Fallback to defaultlocale if translation for the page doesn't exist
| Reported by: | saroyanm | Assignee: | ferris |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | sebastian, kzar, matze, trev | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by saroyanm)
How to reproduce
- Go to https://adblockplus.org/nl/deployments (or any other page which is not translated)
- Observe
Observed behaviour
404 Not found error is shown
Expected behaviour
Fallback to the defaultlocale version of the page as described in the CMS documentation.
Attachments (0)
Change History (7)
comment:2 Changed on 10/12/2015 at 01:01:29 PM by saroyanm
After this changes we can revert the hardcoded implementation of passing locale to the /verifyEmail by current changeset
comment:3 Changed on 10/12/2015 at 01:44:14 PM by sebastian
- Cc matze trev added
- Component changed from Sitescripts to Infrastructure
@trev: IIRC, we realized and discussed that issue around the website migration. However, I don't remember the conclusion anymore.
Anyway, this would be an Infrastructure issue. Therefore also looping in @matze.
comment:4 Changed on 04/25/2016 at 12:27:13 PM by saroyanm
I think the behavior of this issue should be the following:
I think that should be possible to specify in the ngnix configuration:
- Check if /$lang/$path exists
- if it doesn't exist navigate to /$path
- use existing behavior when navigating to the link without $lang part in it ex. -> https://adblockplus.org/verification-success
If nobody has additional concerns I'll suggest move this Ticket forward and implement so.
@Matze you think this is feasible ? Let me know if you need more information regarding this.
comment:5 Changed on 04/25/2016 at 03:26:35 PM by saroyanm
- Description modified (diff)
Apparently there is an exception for this page :/
I've update to the new one.
comment:6 Changed on 09/07/2017 at 07:41:03 PM by ferris
- Owner set to ferris
comment:7 Changed on 09/07/2017 at 07:43:12 PM by ferris
- Resolution set to fixed
- Status changed from new to closed
Fixed on adblockplus.org - continuing the work in http://hub.eyeo.com/issues/3299.
@Dave @Sebastian, I'm not sure if the documentation needs to be updated, or it's a bug. Maybe some setup missing in infrastructure, but probably guys you will know better.
In local environment when the page translation doesn't exists I'm being redirected to the English verision of the page, while when I'm changing defaultlocale to any other locale, I'm getting error.