Opened on 10/22/2015 at 05:59:48 PM
Closed on 12/02/2015 at 11:51:14 AM
#3224 closed change (fixed)
Unbreak filter assistant
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s 2015q4 |
| Cc: | Blocked By: | ||
| Blocking: | #3208 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
#3208 will break the filter assistant because ContentPolicy.refilterNodes() won't work any more. The filter assistant can no longer keep track of the node it is being applied to, they live in different processes.
What to change
Give the filter assistant some kind of node identifier it can work with (worst-case scenario: map node identifiers to nodes in the content processes as long as the filter assistant window is open). Make ContentPolicy.refilterNodes() message the child with that identifier and perform the actual work there.
Attachments (0)
Change History (6)
comment:1 Changed on 10/23/2015 at 05:48:15 PM by trev
- Blocked By 3208 removed
comment:2 Changed on 10/23/2015 at 05:48:26 PM by trev
- Blocking 3208 added
comment:3 Changed on 11/09/2015 at 11:29:26 AM by trev
- Owner set to trev
comment:4 Changed on 11/09/2015 at 01:46:29 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 11/09/2015 at 02:59:43 PM by mario
- Keywords 2015q4 added
comment:6 Changed on 12/02/2015 at 11:51:14 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Platform changed from Unknown / Cross platform to Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Fixed on e10s branch: https://hg.adblockplus.org/adblockplus/rev/8e3224af5ade