Opened on 10/22/2015 at 05:54:59 PM
Closed on 12/02/2015 at 12:24:59 PM
#3223 closed change (fixed)
Unbreak context menu
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s 2015q4 |
| Cc: | Blocked By: | ||
| Blocking: | #3208 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29331687/ |
||
Description (last modified by trev)
Background
#3208 will break the context menu because the data will be attached to nodes in the content process, RequestNotifier.getDataForNode won't be able to access it any more.
What to change
Register a handler for the content-contextmenu observer notification, attach our context data to the addonInfo parameter. This should include the request IDs that can be passed to the filter assistant (see #3224). The UI code should check the global gContextMenuContentData variable - if it can find our data in its addonInfo member then this one should be used. Otherwise it should fall back to the current logic working with the event target without any e10s handling (for SeaMonkey before 2.37 and Thunderbird).
Attachments (0)
Change History (7)
comment:1 Changed on 10/23/2015 at 05:48:15 PM by trev
- Blocked By 3208 removed
comment:2 Changed on 10/23/2015 at 05:48:26 PM by trev
- Blocking 3208 added
comment:3 Changed on 11/09/2015 at 02:59:49 PM by mario
- Keywords 2015q4 added
comment:4 Changed on 11/30/2015 at 05:47:39 PM by trev
- Description modified (diff)
- Owner set to trev
- Ready set
comment:5 Changed on 12/01/2015 at 02:34:43 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 12/01/2015 at 02:49:42 PM by trev
- Review URL(s) modified (diff)
Found a relatively simple solution for the fallback.
comment:7 Changed on 12/02/2015 at 12:24:59 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Platform changed from Unknown / Cross platform to Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
The main part is done here, the fallback is really tricky however.