Opened on 10/22/2015 at 08:17:30 PM
Closed on 11/26/2015 at 01:50:46 PM
Last modified on 12/14/2015 at 12:37:05 PM
#3228 closed change (fixed)
Unbreak object tabs
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s 2015q4 |
| Cc: | Blocked By: | ||
| Blocking: | #3208 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
#3208 will break object tabs because these will run in the content process now - yet they expect communicating with the prefs and ui modules (figuring out whether they are enabled). Also, they will call into the ui module to open the filter assistant when the tab is clicked.
What to change
Split up objectTabs module into objectTabs and child/objectTabs, the latter having most of the code. The tasks of the objectTabs module would be:
- Register the user stylesheet
- Message child/objectTabs whenever it is enabled/disabed
- Receive messages and call into ui module whenever the object tab has been clicked
Attachments (0)
Change History (10)
comment:2 Changed on 10/23/2015 at 05:48:15 PM by trev
- Blocked By 3208 removed
comment:3 Changed on 10/23/2015 at 05:48:26 PM by trev
- Blocking 3208 added
comment:4 Changed on 11/06/2015 at 07:03:58 PM by trev
- Owner set to trev
comment:5 Changed on 11/06/2015 at 07:53:00 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 11/09/2015 at 02:59:29 PM by mario
- Keywords 2015q4 added
comment:7 Changed on 11/26/2015 at 01:50:46 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Platform changed from Unknown / Cross platform to Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 12/14/2015 at 07:25:22 AM by Ross
I don't see object tabs at all for Flash or Java in Firefox 38 or Firefox 45. I have a suspicion this might be my problem though, could someone else double check this?
comment:9 Changed on 12/14/2015 at 12:25:26 PM by trev
It works for me in Firefox 42 and 45 as well as SeaMonkey 2.42 on OS X (tested on https://www.adobe.com/software/flash/about/ with Flash installed). What was your configuration?
comment:10 Changed on 12/14/2015 at 12:37:05 PM by trev
I also tested the 2.6.13.4091-beta build on Ollie's laptop (Firefox 42 on Windows), works fine there as well.
Fixed on e10s branch:
https://hg.adblockplus.org/adblockplus/rev/4628e68d6c41