Opened on 10/22/2015 at 06:13:09 PM

Closed on 12/02/2015 at 01:19:43 PM

#3227 closed change (fixed)

Unbreak element hiding unit tests

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords: e10s 2015q4
Cc: Blocked By:
Blocking: #3108 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29329806/

Description

Background

While #3108 fixed element hiding, element hiding unit tests are broken now.

What to change

It seems that the unit tests make wrong timing assumptions, these need to be adjusted.

Attachments (0)

Change History (4)

comment:1 Changed on 11/06/2015 at 11:57:37 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/06/2015 at 11:57:47 AM by trev

  • Owner set to trev

comment:3 Changed on 11/09/2015 at 02:59:36 PM by mario

  • Keywords 2015q4 added

comment:4 Changed on 12/02/2015 at 01:19:43 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplustests/rev/2e1c5e97bf42

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.