Popup blocking is applied to pages opened by the user in a new tab

[mapx]

Environment

chrome 47 ABP 1.9.3.1488
still happens in Chrome Version 62.0.3202.62 (Official Build) beta (64-bit) ABP 1.13.4.1892

How to reproduce

update easylist
go to
​https://adblockplus.org/forum/viewtopic.php?p=141887#p141887

1.in chrome try to open any of the links there, for example:
​https://ads.nipr.ac.jp/
try clicking the middle mouse button or even open link in a new tab
The attempts will fail due to the filter:

://ads.$popup

2.try the same in firefox ==> no issue, the new tab will be opened.

Expected behavior

Popup blocking filters should not cause tabs opened by the user to be closed.

[trev]

Added Analysis section to the description. From what I remember, checking window.opener wasn't possible in Chrome, maybe Sebastian can confirm.

[trev]

In fact, neither chrome.webNavigation.onBeforeNavigate (sourceTabId) nor chrome.tabs (openerTabId) seem to distinguish between user-opened and website-opened tabs, the tab ID of the original tag is set regardless - much unlike window.opener.

[mapx]

other test case
​http://uptobox.com/w851onwc1ujq

Liste FR contains this filter:

|http://$popup,domain=uptobox.com

clicking the middle mouse button or even open link in a new tab (for example for home link/button) fails.

[sebastian]

As trev indicated above, the webNavigation API doesn't distinguish between actual popups and pages opened in a tab by the user. However It seems to be possible to identify popups by their ​windowType.

[sebastian]

Apparently, I was too ambitious that the Chrome API does what it indicates. Even though "popup" is a documented value for windowType, it's not used for popups created with window.open() as those are presented as regular tabs. So yeah, unfortunately, I don't see any way either to distinguish between actual popups and pages opened in a new tab by the user.

[Lain_13]

Since ABP already wrapping WebSocket, why don't wrap window.open as well? I'm already doing so for a few sites in my RU AdList JS Fixes and it works.

[trev]

Wrapping window.open doesn't work in the same way, as established on ​https://stackoverflow.com/questions/6649742/changing-window-prototype-open-in-a-way-that-isnt-detectable-reversible such manipulation would be trivial for the website to revert.

[kzar]

Is it possible we could use the transitionQualifiers and transitionType keys ​provided by chrome.webNavigation.onCommitted?

When I middle-click a link I get these values:

transitionQualifiers: [],
transitionType: "link"

But when I use window.open(...) I get these:

transitionQualifiers: ["server_redirect"]
transitionType: "link"

(Problem is I think onCommitted is after we block the popups at the moment, so we'd have to change the logic so that they weren't blocked until onComitted fired.)

[mapx]

Probably you can use now Event.isTrusted

​https://developer.mozilla.org/en-US/docs/Web/API/Event/isTrusted

available since chrome 46

same done by uBo
​https://github.com/gorhill/uBlock/issues/2919#issuecomment-325703777

[mapx]

Event.isTrusted was already used here:
https://issues.adblockplus.org/ticket/3828

[mapx]

another case:

Impossible to google the words "popunder" and "clickunder" when ABP is on. 
I was just reading an article about SEO, landing pages and ClickUnder ads 
and at one moment decided to search the word "ClickUnder" using the context
 menu of Google Chrome (right-click the selected words on the page). Seems 
to me it's not ok to recognize the simple text as clickunder or popunder...
Looking forward to ur feedback, thnx!

​https://adblockplus.org/forum/viewtopic.php?f=10&t=54284

workaround:
@@||google.*/search?q=popunder$popup

[mjethani]

We don't really get an Event object in the webNavigation API so we can't use Event.isTrusted

[mapx]

As I posted above it seems uBo fixed such issue
​https://github.com/gorhill/uBlock/commit/2660bee0d20e8355380b1b8c64973601514526cd

I tested the same (last) case in uBo and no issue here. (hmm ... wrong ... I still get a closed popup)

[mapx]

Well, at least the filter above should be added to easylist.