Opened on 11/02/2015 at 05:37:18 PM
Closed on 12/14/2015 at 03:04:20 PM
#3257 closed change (fixed)
Create uninstallation page in adblockplus.org
Reported by: | saroyanm | Assignee: | saroyanm |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Websites | Keywords: | |
Cc: | greiner, lisabielik, sergz, sebastian | Blocked By: | #3354 |
Blocking: | #3269 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29329984/ |
Description (last modified by saroyanm)
Background
To be able to find the reason why users uninstall Adblock Plus we need to create an uninstallation page which will be shown to the user after Adblock Plus uninstallation and will help us collect information about the reason behind uninstallation.
What to change
Implement uninstalation page using current style guide, make it accessible by https://adblockplus.org/{locale}/uninstalled url and consider changes below:
- The page shouldn't be indexed by search engine bots.
- Use current Adblock Plus logo
- The list of the uninstallation reasons should be randomly sorted and should allow the user to choose multiple reasons on each load, beside the Other, namely... option, which should be placed as the last reason (the options should be easily manageable by non developers).
- Have Legal notice link to https://adblockplus.org/impressum in footer (use same style guide as Contributor Credits link in firstRun page)
- Pass the GET parameters below and their values to the submition page (https://adblockplus.org/{locale}/uninstalled-submit).
- addonName
- addonVersion
- application
- applicationVersion
- platform
- platformVersion
- appLocale
- notificationDownloadCount
- The textArea for Other, namely... reason needs to be placed in the new row and shown only when user check Other, namely... option, it also should have 300 characters limitation.
- Changes should be submitted to https://adblockplus.org/{locale}/uninstalled-submit after submit button is clicked using GET HTTP requests, after that submission page should be shown (submission page style guide)
texts
Uninstallation page
- Header
- Adblock Plus has been uninstalled
- Reasons header
- Please select the reason(s) why you uninstalled Adblock Plus:
- Reasons
- I didn't install Adblock Plus.
- Adblock Plus slowed down my browser.
- I don't like the Acceptable Ads program.
- Adblock Plus didn't block all ads.
- I found better ad blocking software.
- Adblock Plus breaks websites that I visit.
- textarea placeholder
- Please explain why you are uninstalling Adblock Plus
- Disclaimer
- By clicking Submit, you are sending your response to Adblock Plus. Please see our privacy policy. ("privacy policy" should be hyperlinked to: https://adblockplus.org/privacy).
- error message
- Please select at least one of the options above
Submission page
- Content
- Data submitted successfully
- Thank you for your participation
Attachments (3)
Change History (39)
comment:1 Changed on 11/02/2015 at 05:59:18 PM by saroyanm
- Component changed from Unknown to Websites
- Description modified (diff)
Changed on 11/02/2015 at 06:02:41 PM by saroyanm
Changed on 11/02/2015 at 06:02:47 PM by saroyanm
Changed on 11/02/2015 at 06:02:54 PM by saroyanm
comment:5 follow-up: ↓ 10 Changed on 11/03/2015 at 08:31:08 AM by philll
- In the current form, the ticket not only affects the website module but also platform. I would recommend to split that up by using one seperate ticket for the extension changes.
- The ticket doesn't specify when the new page shall be loaded / what mechanism triggers that.
- The style guide of the successful submission page is linked after "using POST HTTP requests" without any hint what that implicates.
comment:6 Changed on 11/03/2015 at 03:45:39 PM by greiner
- Cc greiner added
comment:7 Changed on 11/04/2015 at 03:19:43 PM by saroyanm
- Blocking 3269 added
comment:10 in reply to: ↑ 5 ; follow-up: ↓ 12 Changed on 11/04/2015 at 03:37:09 PM by saroyanm
- Cc lisabielik added
Replying to philll:
- In the current form, the ticket not only affects the website module but also platform. I would recommend to split that up by using one seperate ticket for the extension changes.
- The ticket doesn't specify when the new page shall be loaded / what mechanism triggers that.
- The style guide of the successful submission page is linked after "using POST HTTP requests" without any hint what that implicates.
Done
@Lisa as far as I know you are working on current list of the uninstallation reasons, can you please update the ticket with reasons in text section as soon the reasons are ready.
comment:11 Changed on 11/04/2015 at 04:33:31 PM by saroyanm
- Blocked By 3271 added
comment:12 in reply to: ↑ 10 ; follow-up: ↓ 13 Changed on 11/04/2015 at 04:39:36 PM by lisabielik
Replying to saroyanm:
Replying to philll:
- In the current form, the ticket not only affects the website module but also platform. I would recommend to split that up by using one seperate ticket for the extension changes.
- The ticket doesn't specify when the new page shall be loaded / what mechanism triggers that.
- The style guide of the successful submission page is linked after "using POST HTTP requests" without any hint what that implicates.
Done
@Lisa as far as I know you are working on current list of the uninstallation reasons, can you please update the ticket with reasons in text section as soon the reasons are ready.
I have not been working on uninstall reasons. I didn't know I was supposed to be. But, I can start working on them and update this ticket accordingly.
comment:13 in reply to: ↑ 12 ; follow-up: ↓ 14 Changed on 11/04/2015 at 04:44:38 PM by saroyanm
Replying to lisabielik:
Replying to saroyanm:
Replying to philll:
- In the current form, the ticket not only affects the website module but also platform. I would recommend to split that up by using one seperate ticket for the extension changes.
- The ticket doesn't specify when the new page shall be loaded / what mechanism triggers that.
- The style guide of the successful submission page is linked after "using POST HTTP requests" without any hint what that implicates.
Done
@Lisa as far as I know you are working on current list of the uninstallation reasons, can you please update the ticket with reasons in text section as soon the reasons are ready.
I have not been working on uninstall reasons. I didn't know I was supposed to be. But, I can start working on them and update this ticket accordingly.
My bad, seems like I mixed up something here @Phill maybe you can refer to the correct persons who suppose to revisit the questionnaire points.
comment:14 in reply to: ↑ 13 Changed on 11/04/2015 at 04:50:56 PM by lisabielik
Replying to saroyanm:
Replying to lisabielik:
Replying to saroyanm:
Replying to philll:
- In the current form, the ticket not only affects the website module but also platform. I would recommend to split that up by using one seperate ticket for the extension changes.
- The ticket doesn't specify when the new page shall be loaded / what mechanism triggers that.
- The style guide of the successful submission page is linked after "using POST HTTP requests" without any hint what that implicates.
Done
@Lisa as far as I know you are working on current list of the uninstallation reasons, can you please update the ticket with reasons in text section as soon the reasons are ready.
I have not been working on uninstall reasons. I didn't know I was supposed to be. But, I can start working on them and update this ticket accordingly.
My bad, seems like I mixed up something here @Phill maybe you can refer to the correct persons who suppose to revisit the questionnaire points.
@philll I don't mind doing this. Let me know if this should be me or someone else. Thanks!
comment:15 Changed on 11/04/2015 at 06:11:23 PM by saroyanm
- Description modified (diff)
comment:16 Changed on 11/10/2015 at 03:33:50 PM by jobp
- Description modified (diff)
comment:17 Changed on 11/10/2015 at 03:34:30 PM by jobp
Updated the texts according to this document: https://docs.google.com/document/d/17rlrbJ6xS_YwvA9wITzihCsoHZkb9VjSBKpLETLBHCg/edit
The texts can now be treated as final.
comment:18 Changed on 11/10/2015 at 03:35:43 PM by jobp
- Description modified (diff)
comment:19 Changed on 11/10/2015 at 05:44:45 PM by greiner
- Description modified (diff)
@jobp Please avoid linking to private documents unless you intend to make them public.
comment:20 Changed on 11/11/2015 at 02:36:29 PM by saroyanm
- Ready set
comment:21 Changed on 11/11/2015 at 03:21:41 PM by saroyanm
- Description modified (diff)
comment:22 Changed on 11/11/2015 at 05:51:48 PM by saroyanm
- Priority changed from Unknown to P2
comment:23 Changed on 11/11/2015 at 06:01:08 PM by saroyanm
- Owner set to saroyanm
comment:24 Changed on 11/11/2015 at 06:01:23 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:25 Changed on 11/16/2015 at 04:53:09 PM by saroyanm
- Description modified (diff)
comment:26 Changed on 11/25/2015 at 03:25:37 PM by saroyanm
- Blocked By 3349 added
comment:27 Changed on 11/26/2015 at 01:24:47 PM by kzar
- Blocked By 3354 added
comment:28 Changed on 11/26/2015 at 01:36:17 PM by kzar
- Blocked By 3349 removed
comment:29 Changed on 11/27/2015 at 01:22:55 PM by saroyanm
- Blocked By 3271 removed
comment:30 Changed on 11/30/2015 at 01:23:55 PM by sergz
- Cc sergz added
comment:31 Changed on 12/03/2015 at 02:19:27 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:32 Changed on 12/12/2015 at 12:45:51 PM by sebastian
- Cc sebastian added
- Resolution fixed deleted
- Status changed from closed to reopened
I get a 405 on https://adblockplus.org/en/uninstall-abp-submit after submitting the form. However, with the local development server the page loads as expected. Also loading that page with a GET request in production works. It seems that the production server doesn't allow POST requests here.
Also note that the request body isn't recorded in the server log anyway. So we might have to use a GET request to submit that form anyway, in order to evaluate the results.
(On an unrelated note, I also think /uninstalled would be a better, less cryptic/misleading path name than /uninstall-abp)
comment:33 Changed on 12/14/2015 at 10:51:13 AM by saroyanm
- Description modified (diff)
comment:34 Changed on 12/14/2015 at 11:25:00 AM by saroyanm
- Description modified (diff)
comment:35 Changed on 12/14/2015 at 01:56:32 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:36 Changed on 12/14/2015 at 03:04:20 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed