Opened on 11/26/2015 at 01:24:47 PM
Closed on 11/27/2015 at 09:52:28 AM
#3354 closed change (fixed)
[CMS] Enable markdown.extensions.extra extension
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Sitescripts | Keywords: | cms, markdown |
| Cc: | saroyanm, trev, sebastian | Blocked By: | |
| Blocking: | #3257 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Sometimes it's useful to have a Markdown file that contains HTML elements. This works fine generally, but not with block level elements. Luckily the markdown package contains an extension for this.
With the extension enabled HTML block elements with a truthy markdown attribute will have their contents rendered as Markdown. For example <div markdown="1">**Hello world**</div>.
What to change
Enable the markdown.extensions.extra extension for the markdown renderer in cms/converters.py.
Attachments (0)
Change History (3)
Note: See
TracTickets for help on using
tickets.
I have tested and this change has no effect on how web.adblockplus.org, web.adblockbrowser.org and testpages.adblockplus.org are rendered.
I noticed one change to how web.eyeo.com is rendered, but it actually fixes a bug. It turns out we're already this feature in web.eyeo.com/includes/contact/form.md despite the extension not being enabled. I suppose the server must be somehow configured differently as the problem is not present on the live website.