Opened on 11/06/2015 at 12:45:47 PM

Closed on 11/25/2015 at 10:42:35 PM

#3278 closed change (fixed)

Unbreak Issue Reporter

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By:
Blocking: #3222, #3274 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29329823/

Description

Background

With the changes to the RequestNotifier API implemented in #3222 and #3274, the Issue Reporter will no longer work.

What to change

Adjust Issue Reporter code to pass in window IDs rather than the windows themselves.

Attachments (0)

Change History (2)

comment:1 Changed on 11/06/2015 at 01:08:47 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/25/2015 at 10:42:35 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed on e10s branch: ​https://hg.adblockplus.org/adblockplus/rev/83a432e5ed76

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.