Opened on 10/22/2015 at 05:51:54 PM
Closed on 12/02/2015 at 11:28:51 AM
#3222 closed change (fixed)
Unbreak blockable items list
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s 2015q4 |
| Cc: | Blocked By: | #3258, #3278 | |
| Blocking: | #1545, #3208, #3226 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
|
||
Description
Background
#3208 will break blockable items list because the data will be attached to nodes in the content process, RequestNotifier won't be able to access it directly any more.
What to change
Split up our current requestNotifier module into requestNotifier and child/requestNotifier. The former should still export the RequestNotifier class but it would message child/requestNotifier in order to perform the scan. Also, the wnd parameter will need to be replaced by the outer window ID.
Attachments (0)
Change History (23)
comment:1 Changed on 10/22/2015 at 06:07:09 PM by trev
- Blocking 3226 added
comment:2 Changed on 10/23/2015 at 01:41:31 PM by trev
- Blocking 1545 added
comment:3 Changed on 10/23/2015 at 05:48:15 PM by trev
- Blocked By 3208 removed
comment:4 Changed on 10/23/2015 at 05:48:26 PM by trev
- Blocking 3208 added
comment:5 Changed on 10/23/2015 at 11:04:33 PM by trev
- Owner set to trev
comment:10 Changed on 10/29/2015 at 06:53:17 PM by trev
- Review URL(s) modified (diff)
comment:11 Changed on 10/29/2015 at 07:42:23 PM by trev
- Review URL(s) modified (diff)
comment:12 Changed on 11/02/2015 at 02:35:47 PM by trev
- Review URL(s) modified (diff)
comment:13 Changed on 11/02/2015 at 03:00:40 PM by trev
- Review URL(s) modified (diff)
comment:14 Changed on 11/02/2015 at 08:02:47 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:15 Changed on 11/02/2015 at 08:09:03 PM by trev
- Blocked By 3258 added
comment:16 Changed on 11/02/2015 at 08:14:07 PM by trev
- Blocked By 3259 added
comment:17 Changed on 11/03/2015 at 11:00:05 AM by trev
- Review URL(s) modified (diff)
Pushed the first four changes after a bit of reordering:
https://hg.adblockplus.org/adblockplus/rev/ba9dfcc596e5
https://hg.adblockplus.org/adblockplus/rev/964812a1834f
https://hg.adblockplus.org/adblockplus/rev/60c6ad6b376b
https://hg.adblockplus.org/adblockplus/rev/c99ff1f1a463
comment:18 Changed on 11/03/2015 at 11:33:59 AM by trev
- Review URL(s) modified (diff)
comment:19 Changed on 11/06/2015 at 12:45:47 PM by trev
- Blocked By 3278 added
comment:20 Changed on 11/09/2015 at 03:00:08 PM by mario
- Keywords 2015q4 added
comment:21 Changed on 11/11/2015 at 02:18:22 PM by trev
- Review URL(s) modified (diff)
comment:22 Changed on 11/12/2015 at 06:48:09 PM by trev
The remaining changes landed on the e10s branch and will be merged once the blockers are resolved.
comment:23 Changed on 12/02/2015 at 11:28:51 AM by trev
- Blocked By 3259 removed
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Pretty much done, will file two follow-up issues.