Opened on 11/09/2015 at 02:15:30 PM
Closed on 02/26/2016 at 01:17:16 PM
#3288 closed change (fixed)
Improve the way you can edit bookmarks
| Reported by: | sven | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-1.3.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | 2015q4 |
| Cc: | mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Reason
Many users want to rearrange their bookmarks and there is no simple option for that now.
What to change
We will add an "Edit" button top right to the bookmarks section (24px, regular, # 2a2a2a). The detailed style information are in the style guide below.
Beyond this, we will have an edit mode, after clicking the "Edit" button. In our first implementation this edit mode will look very similar to the one which is provided by apples API (example from safari). The button which was called "Edit" will change in the active edit mode to "Done", also the style of the "Done" button will change to 30px, regular, # 0493d6. In addition, the top and the bottom bar will be grayed out with the color # f0f0f0 and the opacity of 80%. The only exception is the "Bookmarks" item in the navigation. This one should be displayed as before.
Please implement the following features when the edit mode is active (please note that those features are standard iOS table view features):
- Tapping on the red delete icon will slide the corresponding bookmark to the left and reveal a "delete" button to the right as shown in this screenshot. Tapping in the revealed delete button will delete the bookmark
- Pressing and holding the sort icon will unlink the bookmark from the list. While still holding the sort icon and dragging it up or down will change the sort order of the corresponding book mark. Releasing the sort icon will place the bookmark at its new sort order position.
- Tapping a bookmark will open its settings.
- Swipe gestures will be deactivated, thus the user can't swipe to navigate to the dashboard or history while in edit mode.
Resources:
Attachments (4)
Change History (19)
Changed on 11/09/2015 at 02:16:28 PM by sven
Changed on 11/09/2015 at 02:18:14 PM by sven
Changed on 11/09/2015 at 02:33:02 PM by sven
comment:2 Changed on 11/09/2015 at 02:34:36 PM by sven
- Cc salsita mario added
- Description modified (diff)
comment:3 Changed on 11/09/2015 at 02:49:28 PM by mario
- Keywords salsita 2015q4 added
Changed on 11/09/2015 at 04:46:19 PM by sven
comment:5 Changed on 11/30/2015 at 12:20:07 PM by jand
comment:6 Changed on 11/30/2015 at 12:44:50 PM by philll
The What to change section doesn't mention any functionality beyond changing colors. If we want this issue to introduce some functionality addressing the issue described in the Background section, we should also think about a way to reset to default/alphabetic order again.
comment:7 Changed on 12/07/2015 at 10:39:31 AM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:8 Changed on 12/07/2015 at 01:46:26 PM by sven
- Description modified (diff)
- Resolution fixed deleted
- Status changed from closed to reopened
comment:9 Changed on 12/07/2015 at 02:27:37 PM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:10 Changed on 12/14/2015 at 01:46:13 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
Batch modify: Added "-next" milestone to recently closed ABB/iOS issues.
comment:11 Changed on 02/18/2016 at 11:19:30 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- What should the functionality be past selecting the edit option?
- Should the user be able to swipe to Dashboard and History from the Edit mode?
comment:12 Changed on 02/19/2016 at 09:37:17 AM by mario
- Cc salsita removed
- Keywords salsita removed
comment:13 Changed on 02/26/2016 at 09:44:06 AM by mario
- Description modified (diff)
- Ready set
comment:14 Changed on 02/26/2016 at 09:54:40 AM by mario
Added missing information as requested by scheer.
comment:15 Changed on 02/26/2016 at 01:17:16 PM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Tester changed from Unknown to Scheer
- Verified working set
- Tapping on the red delete icon will slide the corresponding bookmark to the left and reveal a "delete" button to the right. Tapping on the revealed delete button will delete the bookmark.
- Pressing and holding the sort icon will unlock the bookmark from the list. While still holding the sort icon and dragging it up or down the position will change the sort order of the corresponding bookmark. Releasing the sort icon will place the bookmark at its new sort order position. -Tapping a bookmark will open its settings.
- The user can't swipe to navigate to the dashboard or history while in edit mode.
ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1
Currently, bookmarks are ordering using lexicographic comparing. What will happen if the order will be changed by user and new bookmark will be added? On which place should be insert bookmark?