Opened on 11/09/2015 at 03:36:39 PM

Closed on 12/02/2015 at 11:27:14 AM

Last modified on 12/14/2015 at 11:04:35 AM

#3290 closed defect (fixed)

Adblock Plus child modules don't always start up

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By:
Blocking: #3108 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29329895/

Description

Environment

Adblock Plus 2.6.11.4010 on Firefox 45.0a1 with E10S enabled.

How to reproduce

  1. Start Nightly with Adblock Plus enabled (as opposed to installing/enabling ABP after startup).

Observed behaviour

Child modules aren't always starting up in the content process, in this build this manifests itself as element hiding exceptions not working.

Expected behaviour

Child modules should always start up.

Attachments (0)

Change History (3)

comment:1 Changed on 11/09/2015 at 03:41:23 PM by trev

  • Keywords e10s added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/02/2015 at 11:27:14 AM by trev

  • Blocked By 3208 removed
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed on e10s branch: ​https://hg.adblockplus.org/adblockplus/rev/43d74a86881e

comment:3 Changed on 12/14/2015 at 11:04:35 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding exceptions are working again. I haven't seen them fail while using Nightly.

ABP 2.6.13.4091-beta
Firefox 45 Nightly (2015-12-13) / Ubuntu 14.04

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.