Opened on 11/12/2015 at 03:54:26 AM
Closed on 01/20/2016 at 09:17:47 AM
#3307 closed change (fixed)
Create class adblockplus::log::rotation
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | fred, fhd | Blocked By: | #3306, #3479 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by matze)
As counter-part for issue #3306, we want to extend many of our log-rotation setups to include a final step that uploads the rotated file to the newly introduced, central log-server.
What to do
In order to avoid hard-coding the entire configuration for every log file, the idea is to introduce a template that can handle the most common cases with just a few parameters.
Notes
Since we do not want to introduce too much overhead (especially in testing and deploy) right now, this should be done in a new class named adblockplus::log::rotation, wrapping the existing logrotate module. This is aligned with the other new entities introduced in this context (i.e. adblockplus::log::master and adblockplus::log::uplink), as well as the long-term goal to refactor logrotate into adblockplus::log::* anyway.
Attachments (0)
Change History (4)
comment:1 Changed on 01/07/2016 at 01:28:38 AM by matze
- Blocked By 3479 added
comment:2 Changed on 01/07/2016 at 01:32:10 PM by matze
comment:3 Changed on 01/20/2016 at 09:17:36 AM by matze
comment:4 Changed on 01/20/2016 at 09:17:47 AM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/infrastructure/rev/23ad1f54f6bc