Opened on 11/12/2015 at 11:46:08 AM
Closed on 11/12/2015 at 12:22:42 PM
Last modified on 01/26/2016 at 10:44:21 AM
#3308 closed change (fixed)
Use the devbuild group ID for the devbuild build configurations
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-iOS-1.1.0 |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
We have build configurations for creating devbuilds. However, it is currently not possible to export the app using those, because the app group ID in the entitlements files is not group.org.adblockplus.devbuilds.AdblockPlusSafari, but group.org.adblockplus.AdblockPlusSafari.
What to change
Set the app group ID in the entitlements files to group.org.adblockplus.devbuilds.AdblockPlusSafari when any of the devbuild build configurations are being used. It should still be group.org.adblockplus.AdblockPlusSafari for the non-devbuild build configurations.
Attachments (0)
Change History (4)
comment:1 Changed on 11/12/2015 at 11:47:30 AM by fhd
- Owner set to fhd
comment:2 Changed on 11/12/2015 at 11:50:30 AM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/12/2015 at 12:22:42 PM by fhd
- Milestone set to Adblock-Plus-for-iOS-1.1.0
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 01/26/2016 at 10:44:21 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Looks to be done and now possible to have App Store and Devbuilds installed at the same time.
ABP for iOS / 1.0.1 / 201601221200
iPhone 5S / iOS 9.2
Pushed: https://hg.adblockplus.org/adblockplussafariios/rev/ecf8b726bbb5