Opened on 12/10/2015 at 02:17:11 PM
Closed on 12/15/2015 at 11:49:29 AM
#3403 closed change (fixed)
Add web redirection for the new uninstallation page
| Reported by: | kzar | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | matze, sebastian, sporz, fhd | Blocked By: | |
| Blocking: | #3269 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
In #3257 we have created an uninstallation page https://adblockplus.org/uninstall-abp that should be displayed when the extension is uninstalled. We now need a web redirection to be set up so the properly localised URL can be generated by the extension.
What to change
Set up a redirection for uninstalled so that https://adblockplus.org/redirect?link=uninstalled will redirect to the page.
Ensure that all query parameters apart from link are preserved, for example: https://adblockplus.org/redirect?link=uninstalled&lang=en-GB&addonName=adblockpluschrome&addonVersion=1.9.4&application=chrome&applicationVersion=47.0.2526.73&platform=chromium&platformVersion=47.0.2526.73¬ificationDownloadCount=0
should be redirected to
https://adblockplus.org/en/uninstall-abp?lang=en-GB&addonName=adblockpluschrome&addonVersion=1.9.4&application=chrome&applicationVersion=47.0.2526.73&platform=chromium&platformVersion=47.0.2526.73¬ificationDownloadCount=0
(Note: It is also OK to preserve the link parameter if that would make this much simpler to implement. It's redundant but it wouldn't actually do any harm.)
Attachments (0)
Change History (9)
comment:1 Changed on 12/10/2015 at 02:18:52 PM by kzar
comment:4 in reply to: ↑ description ; follow-up: ↓ 5 Changed on 12/12/2015 at 01:14:38 PM by sebastian
- Cc sporz added
Replying to kzar:
Set up a redirection for uninstall-abp
Since the domain is already adblockplus.org, duplicating abp here seems redundant. Not that we do it for other redirect targets. So I'd simply call it uninstalled. Same for the path of the uninstallation page itself.
Ensure that all query parameters apart from link are preserved
Is that actually necessary? I guess in order to analyze uninstalls we can simply look at the requests for /redirect and the parameters there, ignoring the requests to the actual uninstalled page.
comment:5 in reply to: ↑ 4 Changed on 12/12/2015 at 01:40:58 PM by kzar
Replying to sebastian:
Ensure that all query parameters apart from link are preserved
Is that actually necessary? I guess in order to analyze uninstalls we can simply look at the requests for /redirect and the parameters there, ignoring the requests to the actual uninstalled page.
Yes, I think it's required as the uninstallation page has some JavaScript that takes those query parameters and turns them into hidden inputs in the feedback form.
comment:6 Changed on 12/12/2015 at 01:45:21 PM by sebastian
I see. Ignore that comment then.
comment:8 Changed on 12/13/2015 at 05:28:24 PM by kzar
- Cc fhd added
- Priority changed from Unknown to P2
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
(Me and Sebastian decided to just go ahead with this as Matze is away and it's the last blocker for getting the uninstallation page displayed for Chrome + Opera.)
comment:9 Changed on 12/15/2015 at 11:49:29 AM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
Landed: https://hg.adblockplus.org/infrastructure/rev/fe7ff09ca9b6
And deployed.
@matze I'm guessing this is infrastructure but sorry if I'm wrong.