Opened on 04/16/2014 at 02:47:21 PM
Closed on 04/16/2014 at 05:11:51 PM
Last modified on 05/07/2014 at 04:23:47 PM
#341 closed defect (fixed)
Pop-up blocking fails if the pop-up URL redirects
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.6-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | arthur | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5748752404971520/ |
||
Description
Environment
Firefox 31.0a1 nightly, Adblock Plus 2.5.1.3798, Adblock Plus unit tests 1.0.1a.320.
How to reproduce
- Open chrome://adblockplustests/content/index.html?test=popupBlocker
Observed behaviour
Multiple tests fail, only the immediate pop-up URL can be blocked but not the URL it redirects to. Also, some tests expect to see https://bugzilla.mozilla.org/show_bug.cgi?id=467514 but it appears to have been resolved in current Firefox versions.
Expected behaviour
No test failures.
Attachments (0)
Change History (7)
comment:1 Changed on 04/16/2014 at 02:51:37 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/16/2014 at 05:11:51 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 04/16/2014 at 05:12:20 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
comment:4 Changed on 04/30/2014 at 03:10:52 PM by arthur
If you block the URL the popup redirects to and not the immediate pop-up URL, ABP isn't acually closing the popup/new tab anymore.
E.g. add this filter
||www.google.$popup
and got to your testcase https://bug467514.bugzilla.mozilla.org/attachment.cgi?id=350947. Once you click on "Click here" the new tab should be blocked/closed but isn't.
Let me know if you want a separate bug report for that.
comment:5 Changed on 04/30/2014 at 03:11:13 PM by arthur
- Cc arthur added
comment:6 Changed on 05/02/2014 at 05:42:10 AM by trev
Yes, please create a separate issue for that.
Fixed:
https://hg.adblockplus.org/adblockplus/rev/93060b031f44
https://hg.adblockplus.org/adblockplustests/rev/96e1def5c8c0