Opened on 12/16/2015 at 09:38:00 AM

Closed on 12/16/2015 at 10:53:51 AM

#3418 closed change (fixed)

Replace expression closures in prefs.js

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: #312, #1434 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29332780/

Description

Background

prefs.js is currently causing warnings in Firefox nightly due to its use of expression closures.

What to change

Replace expression closures by arrow functions.

Attachments (0)

Change History (4)

comment:1 Changed on 12/16/2015 at 10:08:03 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/16/2015 at 10:35:25 AM by sebastian

  • Cc sebastian added

Duplicate of #1434?

comment:3 Changed on 12/16/2015 at 10:44:35 AM by sebastian

  • Blocking 312, 1434 added

Never mind. Let's get this landed, addressing the remaining non-standard JS in buildtools separately.

comment:4 Changed on 12/16/2015 at 10:53:51 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Yes, #1434 is rather vague and most of this landed in smaller chunks already.

Fixed: ​https://hg.adblockplus.org/buildtools/rev/f3c4a535f1c7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.