Opened on 12/16/2015 at 11:17:58 AM

Closed on 12/16/2015 at 11:47:25 AM

Last modified on 01/04/2016 at 02:17:57 PM

#3420 closed change (fixed)

Get rid of for each loops in Diagnostics

Reported by: trev Assignee: trev
Priority: P3 Milestone: Diagnostics-1.3.1-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By: #3463
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29332787/

Description (last modified by trev)

Background

for each loops are deprecated and will produce a warning in Firefox 45. Yet our Diagnostics extension is still using them.

What to change

Replace for each loop by for of loops.

What to test

Extension's main window should still work (display results and color them correctly).

Attachments (0)

Change History (3)

comment:1 Changed on 12/16/2015 at 11:21:13 AM by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/16/2015 at 11:47:25 AM by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/abpwatcher/rev/175b67feca73

comment:3 Changed on 01/04/2016 at 02:17:57 PM by trev

  • Blocked By 3463 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.