Opened on 12/16/2015 at 11:23:03 AM

Closed on 12/16/2015 at 11:33:34 AM

Last modified on 12/16/2015 at 12:09:34 PM

#3421 closed change (fixed)

Get rid of for each loops in keySelector.js

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #312, #1434 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29332790/

Description

Background

for each loops are deprecated and will produce a warning in Firefox 45. Yet keySelector.js is still using them.

What to change

Replace for each loop by for of loops.

Attachments (0)

Change History (4)

comment:1 Changed on 12/16/2015 at 11:26:02 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/16/2015 at 11:33:34 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/buildtools/rev/0b8901d596b0

comment:3 Changed on 12/16/2015 at 11:50:36 AM by trev

  • Blocking 312 added

comment:4 Changed on 12/16/2015 at 12:09:34 PM by sebastian

  • Blocking 1434 added

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.