Opened on 12/21/2015 at 09:47:39 AM
Closed on 08/29/2019 at 05:43:18 PM
#3441 closed change (rejected)
Grey out the Adblock Plus icon for pages where blocking isn't possible (e.g. non http/https)
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | greiner, kzar, sebastian, mjethani | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
The Adblock Plus icon remains red for pages where it's not active, for example about:blank and file:// URLs. Perhaps the icon should be grey for those instead.
What to change
- Grey the icon for tabs where Adblock Plus isn't active, for example "about:blank" or the Chrome web store (Chrome only, see #6191).
Attachments (0)
Change History (6)
comment:1 Changed on 01/04/2016 at 05:39:43 PM by greiner
- Cc greiner added
comment:2 Changed on 01/15/2018 at 02:32:24 PM by greiner
- Cc kzar added
- Component changed from User-Interface to Platform
comment:3 follow-up: ↓ 4 Changed on 01/15/2018 at 02:45:57 PM by kzar
- Cc sebastian mjethani added; sven removed
- Component changed from Platform to User-Interface
- Description modified (diff)
- Summary changed from Do we need to grey out ABP icon on non http/https? to Grey out the Adblock Plus icon for non http/https pages, update popup window
I've updated the issue description, but I disagree about this coming under the Platform module. It'll need changes to both adblockplusui and adblockpluschrome, but I think it's ultimately a question about the user interface.
comment:4 in reply to: ↑ 3 Changed on 01/15/2018 at 05:12:36 PM by greiner
Replying to kzar:
I've updated the issue description, but I disagree about this coming under the Platform module. It'll need changes to both adblockplusui and adblockpluschrome, but I think it's ultimately a question about the user interface.
What changes do you think may affect adblockplusui? At least the popup already hides unrelated menu items when you're opening it on such pages.
The extension icons aren't (yet?) part of the UI module, if that's what you're referring to.
comment:5 Changed on 01/15/2018 at 05:21:31 PM by kzar
- Component changed from User-Interface to Platform
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
- Summary changed from Grey out the Adblock Plus icon for non http/https pages, update popup window to Grey out the Adblock Plus icon for pages where blocking isn't possible (e.g. non http/https)
Fair enough, I stand corrected :) It sound like a sensible enough suggestion to me, so I'll mark it Ready.
comment:6 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Sounds more like a question for Platform whether or not they want to introduce a third icon state for non-HTTP(S) pages.