Opened on 12/21/2015 at 12:19:42 PM
Closed on 12/23/2015 at 12:52:41 PM
#3443 closed change (fixed)
Use process script instead of a frame script in Element Hiding Helper
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Element-Hiding-Helper-1.3.6 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Element Hiding Helper currently uses frame scripts in the content process. This causes issues because frame scripts are loaded for each individual tab - so the frame scripts have to load a JavaScript module. It's a waste of memory and causes significant overhead when Element Hiding Helper is disabled (each frame script is performing shutdown actions). Finally, properly unloading the JavaScript module doesn't work because the corresponding chrome package is already unloaded at that point.
What to change
Use process scripts which will automatically create a single instance per process.
Attachments (0)
Change History (2)
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/elemhidehelper/rev/e76102852d84