Opened on 12/21/2015 at 02:08:31 PM
Closed on 01/05/2016 at 01:05:20 PM
Last modified on 02/01/2016 at 04:19:51 PM
#3444 closed change (fixed)
Remove migration code, resetting Prefs.hidePlaceholders
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.10.1-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
In Adblock Plus 1.8.9, we removed the "Hide placeholders of blocked elements" option (#1671). As this feature is still available, but merely hidden from the options page, it gets automatically reset when updating from a version that still had it exposed on the options page.
This migration code soon has been in the extension for a year and 10 releases. So almost all users migrated already and that code can be removed now.
What to change
Remove the migration code, that resets Prefs.hidePlaceholders, when updating from <1.8.8.1285.
Hints for testers
- Make sure that Prefs.hidePlaceholders is set to true by default, that means for example that when an image is blocked with a blocking (not element hiding) filter, that no placeholder show up.
- Make sure that extension initialization works, i.e. that default filter lists are configured and that the first run page shows up on installation; that settings are preserved when updating the extension or restarting the browser.
Attachments (0)
Change History (9)
comment:1 Changed on 12/21/2015 at 02:10:02 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 01/05/2016 at 01:05:20 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 01/29/2016 at 02:20:35 PM by kzar
- Cc kzar added
comment:9 Changed on 02/01/2016 at 04:19:51 PM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
Done.
- Prefs.hidePlaceholders is set to true
- Extensions initialisation works
- The default filter lists are configured and the first run page shows upon instaltion
- Settings are preserved upon upgrading the extension
Chrome 34, 46, 48
Safari 6, 7, 8
Opera 27, 30
Adblock Plus 1.10.0.1539
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/903bf4d3fb78