Opened on 12/21/2015 at 04:15:33 PM
Closed on 12/21/2015 at 07:34:28 PM
Last modified on 01/18/2016 at 09:16:32 AM
#3448 closed defect (fixed)
"TypeError: this.treeElement is null" error when closing Filter Preferences
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P3 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description (last modified by trev)
Environment
Adblock Plus 2.7.0.4095-beta
Firefox 43
How to reproduce
- Click ABP icon and choose Filter preferences.
- Wait a bit and close the window again.
Observed behaviour
"TypeError: this.treeElement is null" exception shows up in Browser Console, thrown by filters-filterview.js line 668. There are no side-effects it seems.
Expected behaviour
No error messages.
Background
It seems that Firefox calls nsITreeView.setTree() with null parameter when the window is closed, this behavior must be new.
Attachments (0)
Change History (4)
comment:2 Changed on 12/21/2015 at 04:21:58 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/21/2015 at 07:34:28 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 01/18/2016 at 09:16:32 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
No treeview related errors appear when closing the console.
ABP 2.7.0.4128-beta
Firefox 43 / 44 / 45 Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplus/rev/03ca2b9e6a7f