Opened on 12/22/2015 at 10:04:54 AM
Closed on 12/28/2015 at 01:19:06 PM
Last modified on 01/19/2016 at 12:40:18 PM
#3449 closed change (fixed)
Use sendRpcMessage instead of sendSyncMessage
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Adblock Plus will currently use sendSyncMessage() in its nsIContentPolicy implementation in order to get a decision from parent. This call isn't re-entrant - no other messages can be sent while we are waiting for a response.
What to change
Use sendRpcMessage() which has exactly the same semantics but is re-entrant.
Attachments (0)
Change History (4)
comment:1 Changed on 12/22/2015 at 10:09:39 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/28/2015 at 01:19:06 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/18/2016 at 09:18:35 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
This has been done and doesn't seem to have broken anything (I couldn't think of a good way to test this? It's just changing some synchronous code to async?).
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 45 / 46.0a1 / Ubuntu 14.04 x64
comment:4 Changed on 01/19/2016 at 12:40:18 PM by trev
In fact, I had trouble testing this myself - it's merely changing some async code to other async code. I couldn't see any impact of this, but as long at it didn't break anything that's fine.
Fixed: https://hg.adblockplus.org/adblockplus/rev/aeba108b8d81