Opened on 12/23/2015 at 12:23:58 PM
Closed on 12/23/2015 at 03:06:49 PM
#3454 closed change (fixed)
Don't mark font requests as indistinguishable on Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently, we map the request type FONT to OTHER on Safari. That means that filters using the $font option will also match requests of type OTHER, and vice-versa. However, requests loading web fonts are actually not visible to the beforeload DOM event, as the they don't have a DOM element but are loaded with a CSS rule. Therfore these requests are not visible to Adblock Plus on Safari and effected filters should rather be ignored than applied to OTHER requests.
What to change
Don't mark FONT requests as indistinguishable on Safari.
Attachments (0)
Change History (2)
comment:1 Changed on 12/23/2015 at 12:25:29 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/23/2015 at 03:06:49 PM by sebastian
- Milestone set to Adblock-Plus-1.10-for-Chrome-Opera-Safari
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/0f057942fa00