Opened on 01/12/2016 at 01:53:21 PM

Last modified on 10/09/2019 at 06:24:53 PM

#3501 new defect

Invalid Message shown when checking for Updates and internet connection is lost

Reported by: passbrains Assignee:
Priority: Unknown Milestone: Adblock-Plus-for-Internet-Explorer-Next
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: sergz, oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29333386/
​https://codereview.adblockplus.org/29333426/

Description (last modified by scheer)

Adapted from ​https://platform.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-125

Environment

none of assigned configurations
ABP version 1.4.798

How to reproduce

1.Install ABP on IE11
2.Now remove the Internet connection or disable the wifi
3.Click on "Check for Updates" on ABP icon

Observed behaviour

The message shown is incorrect is shown is having as "The Error text was ?1?..

Expected behaviour

The Message shown should be proper

Attachments (1)

13317_1447756925_Untitled.jpg​ (157.7 KB) - added by passbrains on 01/12/2016 at 01:53:23 PM.

Download all attachments as: .zip

Change History (8)

Changed on 01/12/2016 at 01:53:23 PM by passbrains

comment:1 Changed on 01/12/2016 at 01:55:33 PM by scheer

  • Cc sergz oleksandr added
  • Description modified (diff)

comment:2 Changed on 01/12/2016 at 02:02:45 PM by sergz

  • Review URL(s) modified (diff)

There are actually two bugs:

  1. The title string is incorrect, the text string is used as the title string [in review].
  2. We basically don't have an error description, so ?1? is not replaced by anything.

Should we just drop The error text was: ?1??

​https://github.com/adblockplus/new-adblockplusie/blob/master/locales/en.ini#L19

comment:3 Changed on 01/12/2016 at 02:35:30 PM by oleksandr

I think it would be better to output "Unknown error" or something like that. Maybe we will have an error text in some cases in future.

comment:4 Changed on 01/12/2016 at 07:28:10 PM by sergz

  • Review URL(s) modified (diff)

comment:5 Changed on 11/21/2016 at 10:51:57 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:6 Changed on 12/22/2016 at 03:18:07 AM by oleksandr

  • Milestone changed from Adblock-Plus-for-Internet-Explorer-1.6 to Adblock-Plus-for-Internet-Explorer-Next

comment:7 Changed on 10/09/2019 at 06:24:53 PM by greiner

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.