Opened on 01/12/2016 at 03:50:22 PM
Closed on 01/12/2016 at 05:17:45 PM
Last modified on 01/18/2016 at 01:35:54 AM
#3502 closed change (fixed)
Don't use expression closures in Issue Reporter
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Issue reporter is using expression closures for some getters. These are deprecated and generate warnings in Firefox 46.
What to change
Replace expression closures by normal functions.
Attachments (0)
Change History (3)
comment:1 Changed on 01/12/2016 at 03:53:44 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/12/2016 at 05:17:45 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/18/2016 at 01:35:54 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
No warning appears in the Firefox console.
ABP 2.7.0.4128-beta
Firefox 46.0a1 / Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplus/rev/207ecd162afb